Valgrinderr #461
Merged
Valgrinderr #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block was alloc'd during nrnpy_hoc (nrnpy_hoc.cpp:2690) The hocmodule refcnt was mistakenly decremented.
|
@nrnhines : could you bit provide details about this fix? Yesterday, me and @jorblancoa were debugging issue with the model which was working fine with Python2 but giving segfault with Python3. The backtrace was looking like this: Simply example with bulletin-board was working fine (relevant discussion here) |
|
I noticed yesterday that although the pyiter3 pull request passed the travis ci that I was seeing |
|
If this is related to pyiter3 only then it's not relevant for the bug that I mentioned. We are using following commit: In case you know any reason that the Python2 model work but when it is ported to Python3 with minor changes would segfault, let me know. (I understand this is very high level description without any details but in case there is common pitfall with NEURON usage). |
|
I don't know that it is relevant, but it may be the fix you need. That bug dates back a long way |
Sorry for confusion - I meant we are using master branch from Tue Oct 29 12:49:07 2019. |
|
This is the kind of thing that can be a revealed bug or not depending on whether the particular |
olupton
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Made sure nightly tag is set correctly * moved manual trigger variables into UI * Fixed various issues for testing on different python versions * Generate artifacts for wheels This fixes #448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix valgrind invalid read error during finalize that could cause segmentation violations and
a memory leak when iterating over variables of a mechanism.