Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing nobrainer docker files #274

Closed
hvgazula opened this issue Feb 15, 2024 · 8 comments · Fixed by #275
Closed

Testing nobrainer docker files #274

hvgazula opened this issue Feb 15, 2024 · 8 comments · Fixed by #275
Assignees

Comments

@hvgazula
Copy link
Contributor

#273

Requested an ec2 instance ssh'ed into it and ran the following lines

git clone [email protected]:neuronets/nobrainer.git
cd nobrainer
docker build -t neuronets/nobrainer:master-cpu -f docker/cpu.Dockerfile .
docker build -t neuronets/nobrainer:master-gpu -f docker/gpu.Dockerfile .

Both failed.

@hvgazula hvgazula self-assigned this Feb 15, 2024
@hvgazula
Copy link
Contributor Author

@hvgazula
Copy link
Contributor Author

@satra thoughts? I will move on to kwyk retraining.

@satra
Copy link
Contributor

satra commented Feb 15, 2024

is nobrainer checked out there? the docker builds assume there is a checkout of nobrainer as that's how dockerhub works. have you tried just building locally on your m2 (adding --platform linux/amd64)

@hvgazula
Copy link
Contributor Author

I tried it on ec2 after cloning and cd'ing and also on github runner via an action. Sure, I can try the above commands again in my mac.

@satra
Copy link
Contributor

satra commented Feb 16, 2024

currently this repo is set up to autobuild on docker hub whenever changes or releases are created. and both did build fine 4 months again when the repo was last updated. it's possible something has changed in those 4 months. but since the base docker image is the same, i would suggest checking that you should be able to test the build locally to identify the issue. it's possible that some other command is no longer available.

regarding adding datalad to it, you can check how we do it in dandi. we simply do this (https://github.com/dandi/dandi-hub/blob/dandi/docker/Dockerfile#L52C1-L55C46) into a conda environment, instead of trying to get it from neurodebian.

@hvgazula
Copy link
Contributor Author

is nobrainer checked out there? the docker builds assume there is a checkout of nobrainer as that's how dockerhub works. have you tried just building locally on your m2 (adding --platform linux/amd64)

image

@satra
Copy link
Contributor

satra commented Feb 26, 2024

since this is really a datalad issue, let's just remove that for now and bring it back after we update the trained-models.

@hvgazula
Copy link
Contributor Author

hvgazula commented Feb 27, 2024

(for later reference) datalad/datalad-osf#161 for debugging

  1. drive link is not working
  2. datalad get is inconsistent with some files.

image

@hvgazula hvgazula linked a pull request Feb 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants