Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Savitzky-Golay filter #139

Closed
niksirbi opened this issue Mar 12, 2024 · 0 comments · Fixed by #163
Closed

Provide a Savitzky-Golay filter #139

niksirbi opened this issue Mar 12, 2024 · 0 comments · Fixed by #163
Assignees
Labels
enhancement New optional feature

Comments

@niksirbi
Copy link
Member

Is your feature request related to a problem? Please describe.
As @sfmig reminded me, this type of filter is very popular for smoothing pose tracks. We should have it as a standard filtering option in movement.

Describe the solution you'd like
Luckily, it's implemented in scipy (see more in-depth explanation here), so it should be simple to apply it to our xarray objects.

Additional context
That said, this filter has disadvantages and alternatives are being proposed.

@niksirbi niksirbi added the enhancement New optional feature label Mar 12, 2024
@niksirbi niksirbi moved this from 🤔 Triage to 📝 Todo in movement progress tracker Mar 12, 2024
@niksirbi niksirbi moved this from 📝 Todo to ⚠️ Priority in movement progress tracker Mar 21, 2024
@sfmig sfmig moved this from ⚠️ Priority to 🚧 In Progress in movement progress tracker Mar 21, 2024
@sfmig sfmig moved this from 🚧 In Progress to ⚠️ Priority in movement progress tracker Mar 21, 2024
@niksirbi niksirbi moved this from ⚠️ Priority to 🚧 In Progress in movement progress tracker May 3, 2024
@github-project-automation github-project-automation bot moved this from 🚧 In Progress to ✅ Done in movement progress tracker May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New optional feature
Projects
Development

Successfully merging a pull request may close this issue.

2 participants