Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implemented a simple UI for uploading datasets using openneuro upload API #14

Merged
merged 14 commits into from
May 23, 2024

Conversation

rmanaem
Copy link
Collaborator

@rmanaem rmanaem commented May 22, 2024

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Refactored url for sending a request to a env var
- Removed dead code
- Replaced sensitive info with env vars
- Added APIError interface
- Fixed typescript errors
@rmanaem rmanaem added the pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 18.60465% with 35 lines in your changes missing coverage. Please review.

Project coverage is 30.15%. Comparing base (59c5134) to head (0fe7430).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
src/App.tsx 15.15% 28 Missing ⚠️
src/utils/type.ts 0.00% 6 Missing ⚠️
src/utils/constants.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #14       +/-   ##
===========================================
- Coverage   58.62%   30.15%   -28.47%     
===========================================
  Files           7        9        +2     
  Lines          29       63       +34     
  Branches        0       15       +15     
===========================================
+ Hits           17       19        +2     
- Misses         12       44       +32     
Flag Coverage Δ
tests 30.15% <18.60%> (-28.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@surchs surchs self-requested a review May 22, 2024 18:41
Copy link

netlify bot commented May 22, 2024

Deploy Preview for upload-ui ready!

Name Link
🔨 Latest commit 0fe7430
🔍 Latest deploy log https://app.netlify.com/sites/upload-ui/deploys/664f68ceb7dbb20008797af2
😎 Deploy Preview https://deploy-preview-14--upload-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs
Copy link
Contributor

surchs commented May 22, 2024

@rmanaem can you explain how I should configure this after cloning so that I can run it? Ideally by putting this info in the README?

src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rmanaem. I left a couple of smaller comments, take a look - none are blockers but some of what you implemented could do with a comment to remind us why you chose it this way and not another. That's usually a good thing to comment: not the "what is happening" but the "why is it happening and why in this way" - especially if it is a bit unusual.

🧑‍🍳

@rmanaem rmanaem mentioned this pull request May 23, 2024
@rmanaem rmanaem merged commit e59e59c into main May 23, 2024
12 checks passed
@rmanaem rmanaem deleted the feat-7 branch May 23, 2024 16:06
Copy link
Contributor

neurobagel-bot bot commented Oct 5, 2024

🚀 PR was released in v0.1.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a bare bone UI to upload data dictionary to OpenNeuroDatasets-JSONLD
2 participants