-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented a simple UI for uploading datasets using openneuro upload API #14
Conversation
Refactored url for sending a request to a env var
- Removed dead code - Replaced sensitive info with env vars - Added APIError interface - Fixed typescript errors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
===========================================
- Coverage 58.62% 30.15% -28.47%
===========================================
Files 7 9 +2
Lines 29 63 +34
Branches 0 15 +15
===========================================
+ Hits 17 19 +2
- Misses 12 44 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for upload-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@rmanaem can you explain how I should configure this after cloning so that I can run it? Ideally by putting this info in the README? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @rmanaem. I left a couple of smaller comments, take a look - none are blockers but some of what you implemented could do with a comment to remind us why you chose it this way and not another. That's usually a good thing to comment: not the "what is happening" but the "why is it happening and why in this way" - especially if it is a bit unusual.
🧑🍳
🚀 PR was released in |
OpenNeuroDatasets-JSONLD
#7Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: