Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker on release, not (just) push #183

Closed
3 tasks
Tracked by #64 ...
surchs opened this issue Aug 22, 2023 · 2 comments
Closed
3 tasks
Tracked by #64 ...

Build Docker on release, not (just) push #183

surchs opened this issue Aug 22, 2023 · 2 comments
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again importance:high We will address this soon and make room for it in upcoming releases. maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@surchs
Copy link
Contributor

surchs commented Aug 22, 2023

Currently we build and push a docker image every time we push to main: https://github.com/neurobagel/bagel-cli/blob/1d4cb5217813cedfbe6d78fcb2821fac72059089/.github/workflows/cd.yml

That only really makes sense for testing builds, not for things we deploy to production (c.f. https://github.com/neurobagel/documentation/wiki/Release-process#what-happens-next-todo).

What we should do is:

@surchs surchs added type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:process Improvement to internal processes importance:high We will address this soon and make room for it in upcoming releases. labels Aug 22, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Sep 22, 2023
@surchs
Copy link
Contributor Author

surchs commented Dec 15, 2023

@surchs surchs closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again importance:high We will address this soon and make room for it in upcoming releases. maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
None yet
Development

No branches or pull requests

1 participant