-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented pipeline_version
and pipeline_name
query fields
#345
Conversation
Added nipoppy namespace
Pull Request Test Coverage Report for Build 11260361393Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @rmanaem!
The new query params look good overall, though I realized during my review that some aspects of the desired query response might still need clarifying, which I tried to do in my comments.
This made me think: maybe we can have a chat about how to ensure we're all on the same page regarding new neuroimaging data properties, as I understand some of this is domain-specific, and possibly hard to intuit. Maybe during the issue spec stage, we can look at more examples of possible forms the input (e.g., derived) metadata can take, and write up a mock example response (which I think we've done a couple times when changing the data model?)
Let me know if you need more clarification on any of the points below!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @rmanaem! I left one sanity check question for myself, and a few 🍒
Have a look, and then 🧑🍳
🚀 PR was released in |
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: