Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Changed the favicon to neurobagel logo #222

Merged
merged 4 commits into from
Nov 15, 2023
Merged

[ENH] Changed the favicon to neurobagel logo #222

merged 4 commits into from
Nov 15, 2023

Conversation

rmanaem
Copy link
Collaborator

@rmanaem rmanaem commented Nov 14, 2023

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@coveralls
Copy link
Collaborator

coveralls commented Nov 14, 2023

Pull Request Test Coverage Report for Build 6867790297

  • 10 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 99.713%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/main.py 10 11 90.91%
Totals Coverage Status
Change from base Build 6856558278: -0.1%
Covered Lines: 695
Relevant Lines: 697

💛 - Coveralls

@alyssadai alyssadai self-requested a review November 14, 2023 22:50
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool PR @rmanaem!

One question about the logo file location, otherwise 🧑‍🍳!

🍒: I'd consider the [MNT] prefix for this PR, but will leave the final decision to you.

app/main.py Show resolved Hide resolved
@rmanaem
Copy link
Collaborator Author

rmanaem commented Nov 15, 2023

I'd consider the [MNT] prefix for this PR, but will leave the final decision to you.

i believe we used [ENH] in query tool and annotation tool so I'll use [ENH] to stay consistent.

@rmanaem rmanaem merged commit 3c44558 into main Nov 15, 2023
4 of 5 checks passed
@rmanaem rmanaem deleted the feat-221 branch November 15, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add neurobagel logo
3 participants