Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old default values for ENV variables #356

Open
surchs opened this issue Oct 16, 2024 · 0 comments
Open

Replace old default values for ENV variables #356

surchs opened this issue Oct 16, 2024 · 0 comments
Labels
maint:refactor Simplifying or restructuring existing code or documentation. quick fix Minimal planning and/or implementation work required. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@surchs
Copy link
Contributor

surchs commented Oct 16, 2024

We have some old / outdated default values for unset ENV variables:

api/app/api/utility.py

Lines 26 to 32 in a17eda8

GRAPH_ADDRESS = EnvVar(
"NB_GRAPH_ADDRESS", os.environ.get("NB_GRAPH_ADDRESS", "206.12.99.17")
)
GRAPH_DB = EnvVar(
"NB_GRAPH_DB", os.environ.get("NB_GRAPH_DB", "test_data/query")
)
GRAPH_PORT = EnvVar("NB_GRAPH_PORT", os.environ.get("NB_GRAPH_PORT", 5820))

Specifically:

  • NB_GRAPH_ADDRESS (should be localhost or something else) and
  • NB_GRAPH_PORT (should be 7200 since GraphDB)

This probably hasn't caused any issues because we deploy via docker-compose where these values are actively set to their correct defaults:

https://github.com/neurobagel/recipes/blob/7b8669530569a5e69f03b740d53373cafec4d1e8/docker-compose.yml#L11-L19

But we should change them anyhow.

@surchs surchs added maint:refactor Simplifying or restructuring existing code or documentation. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs quick fix Minimal planning and/or implementation work required. labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maint:refactor Simplifying or restructuring existing code or documentation. quick fix Minimal planning and/or implementation work required. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: No status
Development

No branches or pull requests

1 participant