Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor request for total number of subjects in matching datasets into separate function #234

Closed
alyssadai opened this issue Nov 30, 2023 · 0 comments · Fixed by #235
Closed
Assignees
Labels
maint:refactor Simplifying or restructuring existing code or documentation. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Nov 30, 2023

This separate request is currently hard to mock b/c it uses the same functions as the primary phenotypic query

api/app/api/crud.py

Lines 133 to 143 in 34ea1fc

matching_dataset_size_results = post_query_to_graph(
util.create_multidataset_size_query(
results_df["dataset_uuid"].unique()
)
)
matching_dataset_sizes = {
ds["dataset_uuid"]: int(ds["total_subjects"])
for ds in util.unpack_http_response_json_to_dicts(
matching_dataset_size_results
)
}

@alyssadai alyssadai added type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:refactor Simplifying or restructuring existing code or documentation. labels Nov 30, 2023
@alyssadai alyssadai added flag:schedule Flag issue that should go on the roadmap or backlog. and removed flag:schedule Flag issue that should go on the roadmap or backlog. labels Nov 30, 2023
@alyssadai alyssadai moved this to Implement - Active in Neurobagel Dec 1, 2023
@alyssadai alyssadai self-assigned this Dec 1, 2023
@alyssadai alyssadai moved this from Implement - Active to Implement - Done in Neurobagel Dec 1, 2023
@rmanaem rmanaem moved this from Implement - Done to Review - Active in Neurobagel Dec 1, 2023
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maint:refactor Simplifying or restructuring existing code or documentation. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant