Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image build in batch mode #818

Merged
merged 2 commits into from
Apr 20, 2022
+3 −2
Merged

Fix image build in batch mode #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7319cca
Fix image build in batch mode
romasku Apr 20, 2022
882cabc
Add changelog
romasku Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.D/818.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed error when trying to build image in batch mode
4 changes: 2 additions & 2 deletions neuro_flow/batch_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ async def user_share(self, user: str, permission: Permission) -> Permission:

class BatchExecutor:
transient_progress: bool = False
run_builder_job: Callable[..., Awaitable[str]] = start_image_build
run_builder_job: Callable[..., Awaitable[str]]

def __init__(
self,
Expand Down Expand Up @@ -500,7 +500,7 @@ def __init__(
self._project_role = project_role
self._is_projet_role_created = False

self._run_builder_job = self.run_builder_job
self._run_builder_job = start_image_build

# A note about default value:
# AS: I have no idea what timeout is better;
Expand Down