From d4e20594d39d8e9377b3b80b8c67f1fc64fbf323 Mon Sep 17 00:00:00 2001
From: Derek Kozikowski <106621615+derekk-nm@users.noreply.github.com>
Date: Thu, 27 Jun 2024 10:02:41 -0400
Subject: [PATCH 1/2] fix nm_get_docker-tags (#341)

add "description" for build_version output in nm_get_docker-tags action.
---
 .github/actions/nm-get-docker-tags/action.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/actions/nm-get-docker-tags/action.yml b/.github/actions/nm-get-docker-tags/action.yml
index dfa5ccc8fb397..2c0e326f3dea3 100644
--- a/.github/actions/nm-get-docker-tags/action.yml
+++ b/.github/actions/nm-get-docker-tags/action.yml
@@ -15,7 +15,7 @@ outputs:
     description: "extra tag for the docker image based on build type, either latest (for RELEASE) or nightly (for NIGHTLY)"
     value: ${{ steps.tags.outputs.extra_tag }}
   build_version:
-    "version of nm-vllm, e.g. 0.4.0, 0.4.0.20240531"
+    description: "version of nm-vllm, e.g. 0.4.0, 0.4.0.20240531"
     value: ${{ steps.tags.outputs.build_version }}
 runs:
   using: composite

From 80701e4d4e297b57963190a11e8e02d37146087e Mon Sep 17 00:00:00 2001
From: Domenic Barbuzzi <dbarbuzzi@gmail.com>
Date: Thu, 27 Jun 2024 10:02:50 -0400
Subject: [PATCH 2/2] Fix `step-status` script (#333)

This PR fixes the `step-status` script, so the comparison cannot be
broken if the variable is unset/empty, preventing the error below:

![Screenshot 2024-06-25
100134-fs8](https://github.com/neuralmagic/nm-vllm/assets/642904/725ab2d9-d589-47c7-b8e8-30d8463528f0)

It also removes some unused variable definitions that were responsible
for this particular instance of the error.
---
 .github/actions/nm-summary-build/action.yml | 2 --
 .github/scripts/step-status                 | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/.github/actions/nm-summary-build/action.yml b/.github/actions/nm-summary-build/action.yml
index 6f0eb3b457a82..b6aa0c5b96da4 100644
--- a/.github/actions/nm-summary-build/action.yml
+++ b/.github/actions/nm-summary-build/action.yml
@@ -20,8 +20,6 @@ runs:
   using: composite
   steps:
   - run: |
-      BUILD_STATUS=${{ inputs.build_status }}
-      BUILD_EMOJI=$(./.github/scripts/step-status ${BUILD_STATUS})
       WHL_STATUS=${{ inputs.whl_status }}
       WHL_EMOJI=$(./.github/scripts/step-status ${WHL_STATUS})
       echo "testmo URL: ${{ inputs.testmo_run_url }}" >> $GITHUB_STEP_SUMMARY
diff --git a/.github/scripts/step-status b/.github/scripts/step-status
index b07f17517be2b..4739dcaa2223a 100755
--- a/.github/scripts/step-status
+++ b/.github/scripts/step-status
@@ -5,7 +5,7 @@
 
 STEP_STATUS=${1}
 
-if [ $STEP_STATUS -eq 0 ]; then
+if [ "$STEP_STATUS" -eq 0 ]; then
     # green check
     echo -e "\xE2\x9C\x85"
 else