From 4fb5e1aa76e197b3022670c9237d7ea401871ec8 Mon Sep 17 00:00:00 2001
From: Varun Sundar Rabindranath <varun@neuralmagic.com>
Date: Wed, 6 Mar 2024 22:34:02 +0000
Subject: [PATCH] workflow fixes

---
 .github/workflows/nightly.yml      |  6 +++---
 .github/workflows/nm-benchmark.yml | 15 ++++++---------
 2 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
index 73ce981470e9f..0445b1d81ac46 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -18,7 +18,7 @@ on:
 # The scheduled job can't take inputs, but the workflow_dispatch jobs can. Resolve that
 # discrepancy and store all the input arguments as environment variables.
 env:
-  push_results_to_gh_pages: "${{ github.event_name == 'schedule' || inputs.push_results_to_gh_pages }}"
+  PUSH_RESULTS_TO_GH_PAGES: "${{ github.event_name == 'schedule' || inputs.push_results_to_gh_pages }}"
 
 jobs:
 
@@ -32,7 +32,7 @@ jobs:
             gitref: '${{ github.ref }}'
             Gi_per_thread: 4
             python: "3.10.12"
-            push_results_to_gh_pages: '${{ env.push_results_to_gh_pages }}'
+            push_results_to_gh_pages: $PUSH_RESULTS_TO_GH_PAGES
         secrets: inherit
 
     # single gpu
@@ -45,5 +45,5 @@ jobs:
             gitref: '${{ github.ref }}'
             Gi_per_thread: 12
             python: "3.10.12"
-            push_results_to_gh_pages: '${{ env.push_results_to_gh_pages }}'
+            push_results_to_gh_pages: $PUSH_RESULTS_TO_GH_PAGES
         secrets: inherit
diff --git a/.github/workflows/nm-benchmark.yml b/.github/workflows/nm-benchmark.yml
index a61cfc4421602..d8d810e41f906 100644
--- a/.github/workflows/nm-benchmark.yml
+++ b/.github/workflows/nm-benchmark.yml
@@ -28,12 +28,9 @@ on:
         type: string
         required: true
       push_results_to_gh_pages:
-        description: "When set to true, the workflow pushes all benchmarking results to gh-pages UI "
+        description: "When set to true, the workflow pushes all benchmarking results to gh-pages UI"
+        type: string
         required: true
-        type: choice
-        options:
-          - 'true'
-          - 'false'
 
   # makes workflow manually callable
   workflow_dispatch:
@@ -63,7 +60,7 @@ on:
         type: string
         required: true
       push_results_to_gh_pages:
-        description: "When set to true, the workflow pushes all benchmarking results to gh-pages UI "
+        description: "When set to true, the workflow pushes all benchmarking results to gh-pages UI"
         type: choice
         options:
           - 'true'
@@ -82,15 +79,15 @@ jobs:
         run: |
           echo "event name is:" ${{ github.event_name }}
           echo "event type is:" ${{ github.event.action }}
-          echo "push result to gh pages : " ${{ input.push_results_to_gh_pages }}
+          echo "push result to gh pages : " ${{ inputs.push_results_to_gh_pages }}
 
       - name: run push
-        if: ${{ input.push_results_to_gh_pages == 'true' }}
+        if: ${{ inputs.push_results_to_gh_pages == 'true' }}
         run: |
           echo "evaled to true : Okay ! I am pushing to gh pages now"
 
       - name: stay put
-        if: ${{ input.push_results_to_gh_pages == 'false' }}
+        if: ${{ inputs.push_results_to_gh_pages == 'false' }}
         run: |
           echo "evaled to false : not pushing"