Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Creating a pool" log message should not be an error #320

Closed
Nogbit opened this issue Jan 12, 2017 · 2 comments
Closed

"Creating a pool" log message should not be an error #320

Nogbit opened this issue Jan 12, 2017 · 2 comments

Comments

@Nogbit
Copy link

Nogbit commented Jan 12, 2017

There are many ways to solve this, I do see that I can pass in my own logger but it's an all or nothing in this module with no way to decipher as a consumer if a message is error or not. The Creating a pool connected to [server] message should not be logged as an error

The alternative is that everything is silent and instead it would be nice if actual errors get logged and info messages (connection pool created) getting logged as something else. Something that can take in a more intelligent logger with different log levels being implemented in this module.

@neumino
Copy link
Owner

neumino commented Jan 12, 2017

You can pass your own logger if you don't want things to be logged in STDERR
https://github.com/neumino/rethinkdbdash#connection-pool

If you log successful connections to STDOUT, and disconnections to STDERR, then you need to look at both logs to know the state of your pool (connected or not). If they are dumped in two different files, this is a pain to do.

@Nogbit
Copy link
Author

Nogbit commented Oct 25, 2017

Crossing my fingers for #355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants