Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy quotes upon insert with returnVals: true yields "ReqlClientError: Client is buggy (failed to deserialize query)." #26

Closed
chrisvariety opened this issue Jun 24, 2014 · 2 comments

Comments

@chrisvariety
Copy link

Pretty simple, seems like a encoding issue with regards to fancy quotes, e.g.

To reproduce: yield r.table('topics').insert({caption: '“'}, {returnVals: true}).run()

ReqlClientError: Client is buggy (failed to deserialize query).
    at Connection._processResponse (/Users/chrismcc/workspace/ti-node/node_modules/rethinkdbdash/lib/connection.js:144:35)
    at Socket.<anonymous> (/Users/chrismcc/workspace/ti-node/node_modules/rethinkdbdash/lib/connection.js:102:22)
    at Socket.EventEmitter.emit (events.js:107:17)
    at readableAddChunk (_stream_readable.js:159:16)
    at Socket.Readable.push (_stream_readable.js:126:10)
    at TCP.onread (net.js:514:20)
From previous event:
    at new Promise (/Users/chrismcc/workspace/ti-node/node_modules/rethinkdbdash/node_modules/bluebird/js/main/promise.js:82:37)
    at Term.run (/Users/chrismcc/workspace/ti-node/node_modules/rethinkdbdash/lib/term.js:90:21)
    at /Users/chrismcc/workspace/ti-node/test.js:5:98
    at GeneratorFunctionPrototype.next (native)
    at next (/Users/chrismcc/workspace/ti-node/node_modules/co/index.js:83:21)
    at /Users/chrismcc/workspace/ti-node/node_modules/co/index.js:56:5
    at Object.<anonymous> (/Users/chrismcc/workspace/ti-node/test.js:6:3)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)
    at Module.load (module.js:349:32)
    at Function.Module._load (module.js:305:12)
    at Function.Module.runMain (module.js:490:10)
    at startup (node.js:124:16)
    at node.js:807:3'

I think this is an issue with rethinkdbdash because the same query works fine in the data explorer.

@neumino
Copy link
Owner

neumino commented Jun 24, 2014

Ah I know what's going on.
It's basically the same bug as rethinkdb/rethinkdb#2446
I just forgot to do the same in rethinkdbdash. I'll fix it sometime today.

Thanks @chrisvariety for reporting it.

@neumino
Copy link
Owner

neumino commented Jun 25, 2014

Released in 1.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants