-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The mobile phone vertical recording effect is very bad #11
Comments
Hi, you can use vertical images but do not rotate them by 90 degrees as shown in your post figure. |
Hi, |
感谢回复!尝试在backbone之前旋转图像然后把features再旋转回来,横竖屏效果基本上没有变化,所以应该和2D特征提取没有关系。继续发现还存在第三种情况,即在第二种情况下,上下运动手机录制数据(第二种情况主要是左右运动手机),重建平面效果也非常差,希望可以得到更多的解决思路! |
Hey @wangshuailpp! Were you able to zero down on the issue, which you saw? I think i am stumbling on the same issue. I will try the workaround that you suggest and dig through the code to understand if there is something that looks not correct. Meanwhile, would be great to know what are your findings. PS: BTW I am using Android/Arcore, for my setup, and have taken care of the necessary details during the data processing steps. |
Hey @ymingxie,
Regards, |
@wangshuailpp @nbansal90 Hi, you can check the camera coordinate and the world coordinate from ARCore, which need to be consistent with the corresponding coordinates in ScanNet: To leverage the prior of gravity we rotate the camera coordinate to a gravity-aligned camera coordinate (https://github.com/neu-vi/PlanarRecon/blob/main/datasets/transforms.py#L65). The world coordinate matters because we assume the -Z direction in the world coordinate is the gravity direction. The camera coordinate matters because both of the predefined anchors and predicted planes are in the gravity-aligned camera coordinate. You'd better make the world and camera coordinate consistent with the coordinate in ScanNet. Otherwise, you may get worse results. Feel free to comment here if you guys have more findings :) |
Thanks @ymingxie for the response and the pointer! |
Hi @nbansal90, were you able to get the solution working on arcore data? |
@Pushkar2307 Even for me Once I rotate the android phone and capture the data and run through the pipeline, I get a fair result (as observed by wangshuailpp). |
Hi, when I record vertical iphone dataset with ios_logger , I get very bad result. Would planarreocn has some pose or rotation requirement? Following are the vertical recording image and result.
When I record horizontal iphone dataset, result is pretty good. Following are the horizontal image and result. Thanks!
The text was updated successfully, but these errors were encountered: