-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix potential leaks of nse/ns streams in case of lost close #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingaikin <[email protected]>
denis-tingaikin
force-pushed
the
fix-netsvc-monitor
branch
from
June 25, 2024 07:24
7be42ab
to
af66f32
Compare
Signed-off-by: denis-tingaikin <[email protected]>
szvincze
approved these changes
Jun 26, 2024
Signed-off-by: denis-tingaikin <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jul 3, 2024
…k@main PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Jul 3, 2024
…k@main (#204) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
This was referenced Jul 3, 2024
This was referenced Jul 3, 2024
nsmbot
added a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Jul 3, 2024
…k@main (#438) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-ipam-vl3@main PR link: networkservicemesh/cmd-ipam-vl3#204 Commit: 8324a49 Author: Network Service Mesh Bot Date: 2024-07-03 09:09:24 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#204) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Jul 3, 2024
…k@main (#229) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jul 3, 2024
…k@main (#691) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jul 3, 2024
…k@main (#505) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-admission-webhook-k8s@main PR link: networkservicemesh/cmd-admission-webhook-k8s#438 Commit: 16748b3 Author: Network Service Mesh Bot Date: 2024-07-03 09:10:22 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#438) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-map-ip-k8s@main PR link: networkservicemesh/cmd-map-ip-k8s#229 Commit: 39225dc Author: Network Service Mesh Bot Date: 2024-07-03 09:10:33 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#229) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-nsmgr@main PR link: networkservicemesh/cmd-nsmgr#691 Commit: 954526e Author: Network Service Mesh Bot Date: 2024-07-03 09:10:46 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#691) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-nsmgr-proxy@main PR link: networkservicemesh/cmd-nsmgr-proxy#505 Commit: 6316920 Author: Network Service Mesh Bot Date: 2024-07-03 09:10:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#505) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Jul 3, 2024
…k@main (#74) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Jul 3, 2024
…k@main (#40) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Jul 3, 2024
…k@main (#140) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-csi-driver@main PR link: networkservicemesh/cmd-csi-driver#74 Commit: 5476fbd Author: Network Service Mesh Bot Date: 2024-07-03 09:12:51 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#74) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-admission-webhook-k8s@main (#12092) PR link: networkservicemesh/cmd-admission-webhook-k8s#438 Commit: 16748b3 Author: Network Service Mesh Bot Date: 2024-07-03 09:10:22 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#438) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-map-ip-k8s@main (#12091) PR link: networkservicemesh/cmd-map-ip-k8s#229 Commit: 39225dc Author: Network Service Mesh Bot Date: 2024-07-03 09:10:33 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#229) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-dashboard-backend@main PR link: networkservicemesh/cmd-dashboard-backend#40 Commit: 2858acf Author: Network Service Mesh Bot Date: 2024-07-03 09:13:07 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#40) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-cluster-info-k8s@main PR link: networkservicemesh/cmd-cluster-info-k8s#140 Commit: ded31b0 Author: Network Service Mesh Bot Date: 2024-07-03 09:13:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#140) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jul 3, 2024
…d-cluster-info-k8s@main (#12096) PR link: networkservicemesh/cmd-cluster-info-k8s#140 Commit: ded31b0 Author: Network Service Mesh Bot Date: 2024-07-03 09:13:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#140) PR link: networkservicemesh/sdk#1641 Commit: 34ab19f Author: Denis Tingaikin Date: 2024-07-03 17:06:02 +0300 Message: - Fix potential leaks of nse/ns streams in case of lost close (#1641) * fix linter * fix ci issues * fix tests --------- Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
NikitaSkrynnik
pushed a commit
to NikitaSkrynnik/sdk
that referenced
this pull request
Jul 25, 2024
…ervicemesh#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: denis-tingaikin <[email protected]>
NikitaSkrynnik
pushed a commit
to NikitaSkrynnik/sdk
that referenced
this pull request
Jul 29, 2024
…ervicemesh#1641) * fix linter Signed-off-by: denis-tingaikin <[email protected]> * fix ci issues Signed-off-by: denis-tingaikin <[email protected]> * fix tests Signed-off-by: denis-tingaikin <[email protected]> --------- Signed-off-by: denis-tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
networkservicemesh/cmd-nsmgr#675
Issue link
networkservicemesh/cmd-nsmgr#675
How Has This Been Tested?
Types of changes