Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop using Policy routes #628

Open
LionelJouin opened this issue Nov 16, 2023 · 2 comments
Open

Infinite loop using Policy routes #628

LionelJouin opened this issue Nov 16, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@LionelJouin
Copy link
Member

I observed an infinite loop generating these logs while using policy routes:

2023-11-14T13:35:52.430492551Z stderr F Nov 14 13:35:52.430�[37m [DEBU] [id:8467b2f1-b369-4877-a4c1-7d0a0239cfa1] [netlink:getFreeTableID] [tableID:4] [type:networkService] �[0m(22.1132689)                        completed
2023-11-14T13:35:52.430495728Z stderr F Nov 14 13:35:52.430�[37m [DEBU] [id:8467b2f1-b369-4877-a4c1-7d0a0239cfa1] [ConnID:dd62cc20-4a40-4b30-959f-893e6b82cbdd] [nsrtid:{NS(4:4026535987) 4}] [type:networkService] �[0m(22.1132690)                        storedTableID

The loop is from here: https://github.com/networkservicemesh/sdk-kernel/blob/v1.11.0/pkg/kernel/networkservice/connectioncontextkernel/ipcontext/iprule/common.go#L93

I have no easy way to reproduce it, but when I could, this patch was not applied:
#627

@LionelJouin LionelJouin added the bug Something isn't working label Nov 16, 2023
@LionelJouin LionelJouin moved this to 🏗 In progress in Meridio Nov 17, 2023
@LionelJouin
Copy link
Member Author

This will solve the problem if delRule fails: #629, but the entry would still exist in nsRTableNextIDToConnID, so other problems could still exist around this problem.

@NikitaSkrynnik NikitaSkrynnik moved this from Todo to In Progress in Release v1.12.0 Dec 6, 2023
@d-uzlov d-uzlov assigned LionelJouin and unassigned NikitaSkrynnik Dec 6, 2023
@NikitaSkrynnik
Copy link
Contributor

Hello @LionelJouin

Could you please clarify: Do you want to fix this problem yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants