Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createpod chain element should delete the pod if container with nse is done #366

Open
denis-tingaikin opened this issue Jun 13, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jun 13, 2022

currently createpod chain element doesn't support a case when nse container is stopping, but other containers in the supplied pod are still running.

For this case we should delete the pod.

Usecase

  1. change scale from zero example
  2. add to template additional container (for example alpine)
  3. run the example (scale from zero)
  4. delete nsc

actual: created pod is not deleting.
expected: created pod is deleting.

Potential fix

Check here https://github.com/networkservicemesh/sdk-k8s/blob/main/pkg/networkservice/common/createpod/server.go#L181 that added nse container is done

@denis-tingaikin denis-tingaikin added the good first issue Good for newcomers label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant