Case insensitive lookup for deserialization type for header parameters #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for deserialization type for header parameters
|
@miklish Is it possible to add a unit test case to ensure that this logic won't be modified accidentally in the future. Thanks. |
|
@stevehu For sure... working on that now |
… deserialized (but not cookie or query params)
… deserialized (but not cookie or query params)
|
Unit tests added to check that header values are properly deserialized even if header name has different case than OpenAPI (i.e.: header names case insensitive). Also added negative unit tests to ensure that query and cookie parameters remain case sensitive. |
stevehu
approved these changes
Feb 6, 2020
stevehu
pushed a commit
that referenced
this pull request
Feb 6, 2020
#123) * (issue #122) Make parameter deserializer do a case insensitive lookup for deserialization type for header parameters * add unit tests to check that headers with arbitrary case are properly deserialized (but not cookie or query params) * add unit tests to check that headers with arbitrary case are properly deserialized (but not cookie or query params)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ParameterDeserializer class in the openapi-meta module of light-rest-4j uses a case sensitive lookup to determine how to deserialize header values. This violates RFC 7230 which states that header names are case insensitive.
See issue #122 for full details.