Preserving suffix # during metachema URI normalization

[pondzix]

In iglu-client we use version of 1.0.39 java-schema-validator. In the code we define meta schema:

http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#

We're blocked with upgrade to newer version, because of URI normalization. Issue is described in detail here.

The case of http normalization can be easily fixed with disabling forceHttps flag introduced in PR, but the problem with trimming # is still present.

Proposed solution

Similar to forceHttps flag, we could introduce boolean option like removeEmptyFragmentSuffix which would be used in normalization. When enabled - remove #, when disable - leave #. Be default it would be enabled to preserve backward compatibility

I prepared PR containing implementation of proposal. First commit contains test reproducing the issue.

@stevehu Let me know what you think 🙂

[stevehu]

@pondzix Thanks a lot for your help. It is a nice fix that preserves backward compatibility. We have several pending issues still in reviewing and testing mode. Once done, I will have another release.

[pondzix]

Awesome @stevehu and thank you for a quick response!