Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Use OpenSSL v3 #742

Closed
hyperxpro opened this issue Aug 30, 2022 · 6 comments
Closed

[Upgrade] Use OpenSSL v3 #742

hyperxpro opened this issue Aug 30, 2022 · 6 comments

Comments

@hyperxpro
Copy link
Contributor

OpenSSL v3 is available and now achieved FIPS 140-2 Validation. This is useful for use cases that need FIPS 140-2 out of the box.

@hasnain-db
Copy link
Contributor

hi @normanmaurer, I'm happy to put in the work to do this - is it as simple as updating the hashes in the file like c2b5d1a ?

I tried doing that locally (updating to 3.0.2) and it worked fine for me in my application, so I wanted to see if it was possible to have the version here upgraded

@hyperxpro
Copy link
Contributor Author

Well, is it just updating hashes and pointing to a new URL? No API change?

@hasnain-db
Copy link
Contributor

@hyperxpro it worked fine in my application, but I'm not sure of how to run the full suite of tests for netty-tcnative and ensure everything works just fine. Happy to put up a PR and have that launch CI jobs if that's acceptable.

@hyperxpro
Copy link
Contributor Author

Sure please do.

Also, can you show Netty logs when you loaded 3.0.0 OpenSSL?

@hasnain-db
Copy link
Contributor

@hyperxpro here's what I saw:

18:08:03.378 [ScalaTest-run] DEBUG io.netty.handler.ssl.OpenSsl - Initialize netty-tcnative using engine: 'default'
18:08:03.380 [ScalaTest-run] DEBUG io.netty.handler.ssl.OpenSsl - netty-tcnative using native library: OpenSSL 3.0.2 15 Mar 2022

Will try to put up a PR in a bit (need to double check my corporate policies)

@hyperxpro
Copy link
Contributor Author

Closed by PR #802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants