Enable setting of stream context options #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set context, not timeout
| @@ -41,6 +41,9 @@ class SmtpMailer extends Nette\Object implements IMailer | |||
| /** @var bool */ | |||
| private $persistent; | |||
|
|
|||
| /** @var array */ | |||
| private $context; | |||
There was a problem hiding this comment.
should be probably named $streamContext or at least mentioned in doc
/** @var array stream context */
private $context;Also fix the false indentation, and on unset stream context in the input options default to NULL.
|
Please add a test. |
| @@ -122,6 +126,11 @@ protected function connect() | |||
| if (!$this->connection) { | |||
| throw new SmtpException($error, $errno); | |||
| } | |||
|
|
|||
| if ($this->streamContext) { | |||
| stream_context_set_option($this->connection, $this->context); | |||
|
Oh god. This is embarrasing. I'm currently in a lot of work and really little time, I'll redo the whole PR tomorrow or next week. |
dg
force-pushed
the
master
branch
2 times, most recently
from
0985d62 to
1d54312
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
c4f379b to
73946cc
Compare
Merged
|
Closed by #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some situations, namely mine, require to set some stream context options. This PR enables just that. User has to set an option array at initialization with an array that fits requirements of http://php.net/manual/en/function.stream-context-set-option.php