feat: remove Node 8 support #478
Conversation
eduardoboucas
added
the
type: feature
⏱ Benchmark resultsComparing with 67cb622
|
package.json
Outdated
| @@ -94,7 +94,7 @@ | |||
| "tmp-promise": "^3.0.2" | |||
| }, | |||
| "engines": { | |||
| "node": ">=8.3.0" | |||
| "node": ">=10.3.0" | |||
There was a problem hiding this comment.
I was torn on whether to use 10.0.0. which we technically should support, or 10.3.0, the lowest version we test against in the CI. @ehmicky what do you think?
There was a problem hiding this comment.
I answered in the other comment. 👍
package.json
Outdated
| @@ -94,7 +94,7 @@ | |||
| "tmp-promise": "^3.0.2" | |||
| }, | |||
| "engines": { | |||
| "node": ">=8.3.0" | |||
| "node": ">=10.3.0" | |||
There was a problem hiding this comment.
Since cli is using >=10.18.0, should we re-use it?
Link to builds usage data from 2 months ago.
Note: if we do so, we would want to update the Node.js version running GitHub actions tests.
cc @JGAntunes @erezrokah too
There was a problem hiding this comment.
That works for me. I'll update.
| @@ -5,33 +5,10 @@ | |||
| dependencyDashboard: true, | |||
| automerge: false, | |||
| packageRules: [ | |||
| { | |||
| // Those cannot be upgraded to a major version until we drop support for Node 8 | |||
| packageNames: [ | |||
There was a problem hiding this comment.
There's a possibility that some of these packages will also have problems in Node 10, but I think we can wait for Renovate to create the PRs and we evaluate them one-by-one. Unless anyone thinks otherwise?
There was a problem hiding this comment.
Absolutely 👍
Many packages from Sindre Sorhus have dropped support for Node 10 recently, but we could check one by one.
| @@ -5,33 +5,10 @@ | |||
| dependencyDashboard: true, | |||
| automerge: false, | |||
| packageRules: [ | |||
| { | |||
| // Those cannot be upgraded to a major version until we drop support for Node 8 | |||
| packageNames: [ | |||
* feat: remove Node 8 support * chore: fix linting error * chore: update minimum Node version
- Summary
Officially removes support for Node 8.
Closes #294.
- Test plan
N/A
- A picture of a cute animal (not mandatory but encouraged)