Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Tests are failing on Node 16 #463

Closed
ehmicky opened this issue May 14, 2021 · 1 comment · Fixed by #464
Closed

Tests are failing on Node 16 #463

ehmicky opened this issue May 14, 2021 · 1 comment · Fixed by #464
Labels
proj/node-16-support type: bug code to address defects in shipped code

Comments

@ehmicky
Copy link
Contributor

ehmicky commented May 14, 2021

Part of https://github.com/netlify/team-dev/issues/15

Tests are failing on Node 16 which most likely indicate this repository is not completely working with Node 16.
@ehmicky ehmicky added the type: bug code to address defects in shipped code label May 14, 2021
@eduardoboucas eduardoboucas mentioned this issue May 14, 2021
Merged
@ehmicky
Copy link
Contributor Author

ehmicky commented May 14, 2021

It appears the problem is fixed by using archiver@v5. However, that version drops support for Node 8, which might create some other issues as mentioned in #294.

We fixed it by importing archiver lazily since Node 8 can only be used in production as part of @netlify/functions-util which uses @netlify/zip-it-and-ship-it but not archiver.

@ehmicky ehmicky mentioned this issue May 14, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
proj/node-16-support type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: upgrade archiver to 5.x netlify/zip-it-and-ship-it
1 participant
@ehmicky