From aca350ab16f32daefae06c7ab9f579e928412e2d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Eduardo=20Bou=C3=A7as?= <mail@eduardoboucas.com>
Date: Wed, 26 May 2021 15:45:58 +0100
Subject: [PATCH] feat: remove Node 8 support (#478)

* feat: remove Node 8 support

* chore: fix linting error

* chore: update minimum Node version
---
 .github/workflows/workflow.yml                |  6 ++--
 package-lock.json                             |  2 +-
 package.json                                  |  2 +-
 renovate.json5                                | 29 ++-----------------
 src/archive.js                                |  6 +---
 .../function.js                               |  1 -
 6 files changed, 9 insertions(+), 37 deletions(-)

diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml
index 1905bf30c..e8ea9051a 100644
--- a/.github/workflows/workflow.yml
+++ b/.github/workflows/workflow.yml
@@ -13,12 +13,12 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
-        node-version: [10.3.0, '*']
+        node-version: [10.18.0, '*']
         exclude:
           - os: macOS-latest
-            node-version: 10.3.0
+            node-version: 10.18.0
           - os: windows-latest
-            node-version: 10.3.0
+            node-version: 10.18.0
       fail-fast: false
     steps:
       - name: Git checkout
diff --git a/package-lock.json b/package-lock.json
index 574bb50a7..3d02c0972 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -52,7 +52,7 @@
         "tmp-promise": "^3.0.2"
       },
       "engines": {
-        "node": ">=8.3.0"
+        "node": ">=10.18.0"
       }
     },
     "node_modules/@ava/babel-plugin-throws-helper": {
diff --git a/package.json b/package.json
index 920e7432b..62f2147e7 100644
--- a/package.json
+++ b/package.json
@@ -94,7 +94,7 @@
     "tmp-promise": "^3.0.2"
   },
   "engines": {
-    "node": ">=8.3.0"
+    "node": ">=10.18.0"
   },
   "ava": {
     "files": [
diff --git a/renovate.json5 b/renovate.json5
index a25eb68bd..cbbda8e8d 100644
--- a/renovate.json5
+++ b/renovate.json5
@@ -5,33 +5,10 @@
   dependencyDashboard: true,
   automerge: false,
   packageRules: [
-    {
-      // Those cannot be upgraded to a major version until we drop support for Node 8
-      packageNames: [
-        'archiver',
-        'ava',
-        'cp-file',
-        'del',
-        'eslint',
-        'execa',
-        'find-up',
-        'get-stream',
-        'locate-path',
-        'p-map',
-        'pkg-dir',
-        'prettier',
-        'precinct',
-        'semver',
-        'yargs',
-      ],
-      major: {
-        enabled: false
-      }
-    },
     {
       // Fake dependencies used in tests
       packageNames: ['test'],
-      enabled: false
-    }
-  ]
+      enabled: false,
+    },
+  ],
 }
diff --git a/src/archive.js b/src/archive.js
index 9d5acc6bd..e4fb52d3f 100644
--- a/src/archive.js
+++ b/src/archive.js
@@ -1,17 +1,13 @@
 const { createWriteStream } = require('fs')
 const { promisify } = require('util')
 
+const archiver = require('archiver')
 const endOfStream = require('end-of-stream')
 
 const pEndOfStream = promisify(endOfStream)
 
 // Start zipping files
 const startZip = function (destPath) {
-  // `archiver` is not compatible with Node 8, so we lazy-load it and defer its
-  // execution to when absolutely needed. This way, functions that don't create
-  // an archive can still work in Node 8.
-  // eslint-disable-next-line node/global-require
-  const archiver = require('archiver')
   const output = createWriteStream(destPath)
   const archive = archiver('zip', { level: ZIP_LEVEL })
   archive.pipe(output)
diff --git a/tests/fixtures/node-module-optional-catch-binding/function.js b/tests/fixtures/node-module-optional-catch-binding/function.js
index 390ba1259..c9f12ee56 100644
--- a/tests/fixtures/node-module-optional-catch-binding/function.js
+++ b/tests/fixtures/node-module-optional-catch-binding/function.js
@@ -3,7 +3,6 @@ const noop = () => {}
 module.exports.handler = () => {
   try {
     noop()
-    // eslint-disable-next-line node/no-unsupported-features/es-syntax
   } catch {
     // ¯\_(ツ)_/¯
   }