feat: remove Node 8 support (#478)

* feat: remove Node 8 support

* chore: fix linting error

* chore: update minimum Node version

.github/workflows/workflow.yml

@@ -13,12 +13,12 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
-        node-version: [10.3.0, '*']
+        node-version: [10.18.0, '*']
         exclude:
           - os: macOS-latest
-            node-version: 10.3.0
+            node-version: 10.18.0
           - os: windows-latest
-            node-version: 10.3.0
+            node-version: 10.18.0
       fail-fast: false
     steps:
       - name: Git checkout

package.json

@@ -94,7 +94,7 @@
     "tmp-promise": "^3.0.2"
   },
   "engines": {
-    "node": ">=8.3.0"
+    "node": ">=10.18.0"
   },
   "ava": {
     "files": [

renovate.json5

@@ -5,33 +5,10 @@
   dependencyDashboard: true,
   automerge: false,
   packageRules: [
-    {
-      // Those cannot be upgraded to a major version until we drop support for Node 8
-      packageNames: [
-        'archiver',
-        'ava',
-        'cp-file',
-        'del',
-        'eslint',
-        'execa',
-        'find-up',
-        'get-stream',
-        'locate-path',
-        'p-map',
-        'pkg-dir',
-        'prettier',
-        'precinct',
-        'semver',
-        'yargs',
-      ],
-      major: {
-        enabled: false
-      }
-    },
     {
       // Fake dependencies used in tests
       packageNames: ['test'],
-      enabled: false
-    }
-  ]
+      enabled: false,
+    },
+  ],
 }

src/archive.js

@@ -1,17 +1,13 @@
 const { createWriteStream } = require('fs')
 const { promisify } = require('util')
 
+const archiver = require('archiver')
 const endOfStream = require('end-of-stream')
 
 const pEndOfStream = promisify(endOfStream)
 
 // Start zipping files
 const startZip = function (destPath) {
-  // `archiver` is not compatible with Node 8, so we lazy-load it and defer its
-  // execution to when absolutely needed. This way, functions that don't create
-  // an archive can still work in Node 8.
-  // eslint-disable-next-line node/global-require
-  const archiver = require('archiver')
   const output = createWriteStream(destPath)
   const archive = archiver('zip', { level: ZIP_LEVEL })
   archive.pipe(output)

tests/fixtures/node-module-optional-catch-binding/function.js

@@ -3,7 +3,6 @@ const noop = () => {}
 module.exports.handler = () => {
   try {
     noop()
-    // eslint-disable-next-line node/no-unsupported-features/es-syntax
   } catch {
     // ¯\_(ツ)_/¯
   }