fix(perf): refactor the content-type check from startsWith("text/html") to === "text/html"
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to `=== "text/html" `"text/html"` should be the only value that we act against as that is the only entry in the IANA text type registry which indicates HTML content (https://www.iana.org/assignments/media-types/media-types.xhtml#text). Also, the HTTP header/field values can not begin or end with whitespace (https://www.rfc-editor.org/rfc/rfc9110.html#section-5.5), which is why we can use a strict equality against the exact string "text/html".
✅ Deploy Preview for csp-nonce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JakeChampion
changed the title
startsWith("text/html") to `=== "text/html"startsWith("text/html") to `=== "text/html"
JakeChampion
changed the title
startsWith("text/html") to `=== "text/html"startsWith("text/html") to === "text/html"
khendrikse
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"text/html"should be the only value that we act against as that is the only entry in the IANA text type registry which indicates HTML content (https://www.iana.org/assignments/media-types/media-types.xhtml#text).Also, the HTTP header/field values can not begin or end with whitespace (https://www.rfc-editor.org/rfc/rfc9110.html#section-5.5), which is why we can use a strict equality against the exact string "text/html".