Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add correct ava + typescript setup #96

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix: add correct ava + typescript setup #96

merged 1 commit into from
Dec 2, 2022

Conversation

MarcL
Copy link

@MarcL MarcL commented Dec 1, 2022

ava was set up incorrectly and complained with SyntaxErrors when importing our modules into test modules.
This PR bumps the TypeScript version and adds in ts-node to correctly set up ava

@MarcL MarcL requested a review from a team December 1, 2022 16:50
nickytonline
nickytonline previously approved these changes Dec 1, 2022
Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @MarcL and going to go ahead and approve as we tested this out together. 🚀

@MarcL
Copy link
Author

MarcL commented Dec 2, 2022

@nickytonline I've just pushed a rebase from main to fix the lock file conflict. Can you reapprove, please? Thanks!

@MarcL MarcL merged commit 910d8ad into main Dec 2, 2022
@MarcL MarcL deleted the fix-ava-testing branch December 2, 2022 12:41
Copy link

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 x 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants