feat: add prefix filtering and loop detection for local images #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
ascorbic
force-pushed
the
mk/localprefix
branch
from
3062da5
to
297a914
Compare
ascorbic
changed the title
ascorbic
force-pushed
the
mk/localprefix
branch
from
297a914
to
4e6937a
Compare
2 tasks
nickytonline
reviewed
Oct 5, 2022
| return { | ||
| statusCode: 400, | ||
| body: 'Invalid source image path', | ||
| headers: plainText |
There was a problem hiding this comment.
I guess for all the spots with plain text headers we always want these responses as text, i.e. no scenario where it would make sense as JSON?
| const isLocal = !id.startsWith('http://') && !id.startsWith('https://') | ||
| if (isLocal) { | ||
| const url = new URL(event.rawUrl) | ||
| url.pathname = id | ||
| if (localPrefix && !url.pathname.startsWith(localPrefix)) { |
There was a problem hiding this comment.
We're giving the option to pass in a localPrefix to IPX for scenarios like Next.js that have a dedicated folder for static images correct?
ericapisani
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a
localPrefixoption, ensuring that local images can only be served from a specific path. Additionally, adds a header to prevent infinite loops where the source image matches the ipx server. This is done by adding anx-ipx-subrequestheader to source image requests. If this header is detected then it means there's a request loop.