Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for base64-encoded props #6

Merged
merged 1 commit into from
Feb 22, 2022
Merged

feat: add support for base64-encoded props #6

merged 1 commit into from
Feb 22, 2022

Conversation

ascorbic
Copy link

Adds support for URLs that base64-encode the URL and modifiers

@ascorbic ascorbic added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 22, 2022
erezrokah
erezrokah approved these changes Feb 22, 2022
View reviewed changes
Copy link

@erezrokah erezrokah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Only thing I can think of is possibly providing a better default to basePath to handle known cases (e.g. always strip /_gatsby/image/ or /.netlify/builders/ipx/ or /_ipx) which is unrelated to this PR

@ascorbic ascorbic merged commit eca4c08 into main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @erezrokah