Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalForageTest #550

Merged
merged 2 commits into from
Jan 4, 2018
Merged

LocalForageTest #550

merged 2 commits into from
Jan 4, 2018

Conversation

vencax
Copy link
Contributor

@vencax vencax commented Aug 24, 2017

I got many errors in log and after investigating: quota for temporary storage was full due to disk full. Maybe useful test in this PR.
(https://www.html5rocks.com/en/tutorials/offline/quota-research/)
cheers

Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! We should probably get it out of the main API file, so I'm thinking:

  • initialize localforage in a new lib/LocalForage.js script, and import from there
  • move this test there and run it during initialization

@vencax
Copy link
Contributor Author

vencax commented Dec 30, 2017

rebased && done

@verythorough
Copy link
Contributor

Deploy preview ready!

Built with commit 020cf12

https://deploy-preview-550--netlify-cms-www.netlify.com

@verythorough
Copy link
Contributor

Deploy preview ready!

Built with commit 020cf12

https://deploy-preview-550--cms-demo.netlify.com

Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vencax!

@erquhart erquhart merged commit b927c8a into decaporg:master Jan 4, 2018
@vencax vencax deleted the localforage_quota_check branch January 4, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants