Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Localhost subdomains #5

Open
pomber opened this issue Feb 21, 2019 · 3 comments
Open

Localhost subdomains #5

pomber opened this issue Feb 21, 2019 · 3 comments

Comments

@pomber
Copy link

pomber commented Feb 21, 2019

Hey, there's a special case where the auth is failing for me: using subdomains on localhost.
For example I use: http://gitlab.localhost:3000 in this PR.

There are a few places where you compare the location.hostname with "localhost", it fails when hostanme is something like foo.localhost. Maybe you can compare it with location.hostname.split('.').pop().

@swyxio
Copy link
Contributor

swyxio commented Feb 21, 2019

hey pomber, this repo isnt actively maintained. if you wanna PR a fix, i'll merge and republish for you but not actively fixing beyond that

@pomber
Copy link
Author

pomber commented Feb 21, 2019

Thanks swyx, I think the real issue may be in https://api.netlify.com/auth/done. Is there another repo for that one?

@swyxio
Copy link
Contributor

swyxio commented Feb 21, 2019

our open api is here https://open-api.netlify.com/#/default but i can't find /auth/done... i'm not an api expert tho. tagging @futuregerald just in case

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants