Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add shared node config #278

Merged
merged 1 commit into from
Jan 28, 2021
Merged

chore: add shared node config #278

merged 1 commit into from
Jan 28, 2021

Conversation

erezrokah
Copy link
Contributor

In preparation for #265 (I would like to add a test case for it).

Initial work to align this repo with our other repos.

Didn't do the release-please part yet due to

"version": "npm run babelify && git add browser/gotrue.js",
.

I also disabled linting of README.md for now since too much stuff is broken.

@erezrokah erezrokah requested a review from ehmicky January 28, 2021 17:57
@erezrokah erezrokah added the type: chore work needed to keep the product and development running smoothly label Jan 28, 2021
@erezrokah erezrokah force-pushed the chore/add_config_node branch from 40df566 to 9669530 Compare January 28, 2021 17:59
@erezrokah erezrokah force-pushed the chore/add_config_node branch from 9669530 to a6ccf8e Compare January 28, 2021 18:02
// mock window
global.window = { atob: (base64) => Buffer.from(base64, 'base64').toString('ascii') };

test('should parse token in ctor', (t) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants