Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot unmarshal array into Go struct field GatewayClaims.aud of type string #66

Open
vnugent opened this issue Aug 27, 2021 · 0 comments

Comments

@vnugent
Copy link

vnugent commented Aug 27, 2021

- Do you want to request a feature or report a bug?
Bug

- What is the current behavior?

git-gateway can't handle Auth0 token with audience formatted as array.

Auth0 JWT:

{
  "iss": "...",
  "sub": " ...",
  "aud": [
    "https://git-gateway" <-- array
   ],
  ...
}

git-gateway returns:  {"code":401,"msg":"Invalid token: json: cannot unmarshal array into Go struct field GatewayClaims.aud of type string"}

- If the current behavior is a bug, please provide the steps to reproduce.

  1. Go to jwt.io and generate a new token.
  2. Change aud in the payload from a string to an array. Ex:

From

 "aud": "https://git-gateway"

to

"aud": [
    "https://git-gateway"
   ],

- What is the expected behavior?
git-gateway can handle audience as an array

- Please mention your Go version, and operating system version.
Running in a container built with the included Dockerfile.


Edit: it is a known issue the jwt library: dgrijalva/jwt-go#308

token, err := p.ParseWithClaims(bearer, &GatewayClaims{}, func(token *jwt.Token) (interface{}, error) {

Update: I have made a fix. Upgrading jwt library to the latest. PR to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant