chore(ci): fix don't cache npm cache dir between workflow execs #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
📊 Benchmark resultsPackage size: 327 MBLegend
|
JGAntunes
added
automerge
erezrokah
approved these changes
Aug 31, 2021
JGAntunes
force-pushed
the
chore/fix-ci-npm-cache
branch
from
05edf16
to
5fc00e7
Compare
|
Apologies @erezrokah I ended up finding - actions/setup-node#302 - so I dismissed your original review. This change should put the cache in a working state 👍 |
erezrokah
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts - 9e7f417 -
caching only seems to work with(EDIT: the path for the lockfile can be configured apparently - actions/setup-node#302)package-lock.jsonfiles and doesn't seem to supportnpm-shrinkwrap(see https://github.com/netlify/cli/runs/3471879986)