Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect pnpm version #5663

Open
1 task
benmccann opened this issue May 24, 2024 · 1 comment
Open
1 task

Automatically detect pnpm version #5663

benmccann opened this issue May 24, 2024 · 1 comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@benmccann
Copy link

benmccann commented May 24, 2024

Which problem is this feature request solving?

Netlify uses pnpm 7 by default. If your project is using pnpm 8 or pnpm 9 then the deployment will fail unless you manually specify the packageManager field. With pnpm 9, specifying the packageManager field will then in turn cause difficulties with running the project locally for users who are not using corepack (pnpm/pnpm#8087)

Describe the solution you'd like

Look at the lockfile version to choose a compatible version of pnpm without the user needing to manually specify it in the packageManager field just as Vercel does.

Pull request (optional)

  • I can submit a pull request.
@benmccann benmccann added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 24, 2024
@Skn0tt Skn0tt assigned Skn0tt and unassigned Skn0tt May 27, 2024
@Skn0tt
Copy link
Contributor

Skn0tt commented May 27, 2024

Yes, that sounds like something we should implement. I've surfaced this internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

No branches or pull requests

2 participants