Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't ReusableSource have associated type for cell identifiers? #44

Open
netcosportsanatoly opened this issue Apr 25, 2019 · 3 comments

Comments

@netcosportsanatoly
Copy link
Contributor

var selectedCellIds: Set<String> { get set }

@sergeimikhan
Copy link
Collaborator

@netcosportsanatoly could you please clarify what do you mean? Do you want to have a generic type for cells ids?

@netcosportsanatoly
Copy link
Contributor Author

May be generic, may be not. It depends from class conforming ReusableSource protocol.
I would like to use enums or integers for views with static content.

@sergeimikhan
Copy link
Collaborator

  1. It's really reasonable. 2. It will be really difficult to implement it with the current design of Cellable protocol. We will need to adjust it to also use generic type. And the most difficult point is the connection between Cellable implementation and Source to use same type of cell id.

If you have idea how to handle this, please share with us.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants