Errors with PHP 5.4

[Toutouwai]

Similar to another issue raised earlier...

The module is giving compile errors in PHP 5.4 due to the way empty() is used in the following lines:

ModuleReleaseNotes/GithubRepositoryAdaptor.php

Line 161 in c499c2b

if (is_string($startref) && !empty(trim($startref))) {

ModuleReleaseNotes/BitbucketRepositoryAdaptor.php

Line 113 in c499c2b

if (is_string($startref) && !empty(trim($startref))) {

ModuleReleaseNotes/ModuleReleaseNotes.module

Line 801 in c499c2b

if (!empty(trim($notes))) $f->notes = $notes;

[netcarver]

@Toutouwai Thanks Robin. Working on this now.

[netcarver]

@Toutouwai Could you try branch php54 and let me know if that fixes things for you?

[Toutouwai]

Yep, that's fixed it. Thanks.

[netcarver]

Added to master and pushed this bugfix as release 0.10.8. Closing this issue, thank you!