Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17289 enforce minimum password strength #17299

Merged
merged 11 commits into from
Aug 30, 2024
Merged

17289 enforce minimum password strength #17299

merged 11 commits into from
Aug 30, 2024

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented Aug 29, 2024 •
edited
Loading

Fixes: #17289

Enforce default minimum password strength:

  • 12 characters minimum
  • similarities to user attributes (first name, last name, email)
  • common password check
  • must contain one number, one upper-case letter and one lower-case letter.

Change Password | NetBox 2024-08-29 08-58-46

@arthanson arthanson changed the title DRAFT: 17289 enforce minimum password strength 17289 enforce minimum password strength Aug 29, 2024
@arthanson arthanson marked this pull request as ready for review August 29, 2024 17:01
@jeremystretch jeremystretch added this to the v4.1 milestone Aug 29, 2024
jeremystretch
jeremystretch requested changes Aug 30, 2024
View reviewed changes
netbox/users/tests/test_views.py Outdated Show resolved Hide resolved
netbox/users/tests/test_api.py Show resolved Hide resolved
netbox/utilities/password_validation.py Outdated Show resolved Hide resolved
netbox/utilities/password_validation.py Outdated Show resolved Hide resolved
netbox/utilities/password_validation.py Outdated Show resolved Hide resolved
netbox/utilities/password_validation.py Outdated Show resolved Hide resolved
netbox/users/tests/test_views.py Show resolved Hide resolved
jeremystretch
jeremystretch requested changes Aug 30, 2024
View reviewed changes
netbox/netbox/settings.py Outdated Show resolved Hide resolved
netbox/netbox/settings.py Outdated Show resolved Hide resolved
netbox/users/tests/test_api.py Show resolved Hide resolved
@jeremystretch jeremystretch merged commit 00874ac into feature Aug 30, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17289-password-strength branch August 30, 2024 21:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch Awaiting requested review from jeremystretch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@arthanson @jeremystretch