9627 use ArrayField on VLANGroup for allowed VLANs #16710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
jeremystretch
requested changes
Jul 9, 2024
|
@jeremystretch looks good to me |
jeremystretch
approved these changes
Jul 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9627
Note: The min_vid and max_vid filters were removed, It might be possible to do some PostGres fu to filter inside the arrays for min / max. Could also make internal fields storing the array min and max and filter against that. Tried storing the expanded array as individual items, but that runs into the PostGres row size limit so is not tenable.
Currently using
vlan_id_rangesfor the name, wondering if allowed_vlans or allowed_vlan_ids would be a better name?