Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select all with bulk edit only changes the currently visible objects #17963

Closed
julianstolp opened this issue Nov 8, 2024 · 1 comment · Fixed by #17994
Closed

Select all with bulk edit only changes the currently visible objects #17963

julianstolp opened this issue Nov 8, 2024 · 1 comment · Fixed by #17994
Assignees
@jeremystretch
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@julianstolp
Copy link

Deployment Type

Self-hosted

Triage priority

N/A

NetBox Version

v4.1.6

Python Version

3.12

Steps to Reproduce

  1. select all objects using the Toggle all checkbox
  2. tick the box Select all xxx object matching query
  3. go to Edit Selected
  4. change something and go to Apply

Expected Behavior

All selected objects will be modified.

Observed Behavior

Only the current visible objects get changed, if all objects are visible all get changed. The bulk delete is unaffected.
image
image
@julianstolp julianstolp added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Nov 8, 2024
@bctiemann bctiemann added the severity: low Does not significantly disrupt application functionality, or a workaround is available label Nov 8, 2024 — with Linear
@bctiemann bctiemann removed the status: needs triage This issue is awaiting triage by a maintainer label Nov 8, 2024
@bctiemann bctiemann added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Nov 8, 2024 — with Linear
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available labels Nov 12, 2024
@jeremystretch jeremystretch self-assigned this Nov 12, 2024
@jeremystretch
Copy link
Member

I've traced this to a regression in 6a316df, where the bulk edit form is initialized using POST data. This specific change doesn't appear to be needed for the functionality implemented under #17789, so I'm going to remove it.

jeremystretch added a commit that referenced this issue Nov 12, 2024
@jeremystretch
Fixes #17963: Fix selection of all listed objects during bulk edit
8eb68b5
@jeremystretch jeremystretch mentioned this issue Nov 12, 2024
Merged
jeremystretch added a commit that referenced this issue Nov 12, 2024
@jeremystretch
Fixes #17963: Fix selection of all listed objects during bulk edit
2ed0534
jsenecal pushed a commit to jsenecal/netbox that referenced this issue Nov 12, 2024
@jeremystretch @jsenecal
Fixes netbox-community#17963: Fix selection of all listed objects dur…
4ca156d 
…ing bulk edit
This was referenced Nov 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #17963: Fix selection of all listed objects during bulk edit netbox-community/netbox
3 participants
@bctiemann @jeremystretch @julianstolp