Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Changelog' tab not visible for non-admin accounts #17387

Closed
peteeckel opened this issue Sep 5, 2024 · 3 comments · Fixed by #17390
Closed

'Changelog' tab not visible for non-admin accounts #17387

peteeckel opened this issue Sep 5, 2024 · 3 comments · Fixed by #17390
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@peteeckel
Copy link
Contributor

Deployment Type

Self-hosted

NetBox Version

4.1.0

Python Version

3.12

Steps to Reproduce

  1. Create a user with view permission for all object types and log in as that user.
  2. Open an object detail view for an arbitrary object (e.g. an IPAM IP Address).

Expected Behavior

The 'Changelog' tab should be visible.

Observed Behavior

No 'Changelog' tab is shown.

@peteeckel peteeckel added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Sep 5, 2024
@peteeckel
Copy link
Contributor Author

The issue is in the definition of the ObjectChangeLogView class. The permission that is required according to the class is extras.view_objectchange while it should be core.view_objectchange.

I'll provide a PR if accepted.

@peteeckel
Copy link
Contributor Author

In fact there are multiple instances of the same bug:

(netbox) [root@dns netbox]# git grep 'extras\..*_objectchange'
netbox/netbox/views/generic/feature_views.py:        permission='extras.view_objectchange',
netbox/templates/account/profile.html:  {% if perms.extras.view_objectchange %}
netbox/templates/users/user.html:  {% if perms.extras.view_objectchange %}

@arthanson arthanson added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Sep 5, 2024
@arthanson
Copy link
Collaborator

I've assigned to you @peteeckel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants