Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestJS Terminus has an undeclared dependency on Axios #1991

Closed
2 tasks done
osidenate opened this issue Aug 10, 2022 · 1 comment
Closed
2 tasks done

NestJS Terminus has an undeclared dependency on Axios #1991

osidenate opened this issue Aug 10, 2022 · 1 comment

Comments

@osidenate
Copy link

Did you read the migration guide?

  • I have read the whole migration guide

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Potential Commit/PR that introduced the regression

No response

Versions

8.0.6 -> 9.1.0

Describe the regression

There is a new dependency on axios from a type definition file.

axios-import-error

The dependency is not specified in the package.json. Including @nestjs/axios as a peerDependency may help resolve this.

Minimum reproduction code

Expected behavior

Should be able to reference @nestjs/terminus without having to install axios directly.

Other

No response

@osidenate osidenate changed the title NestJS Terminus has a dependency on Axios NestJS Terminus has an undeclared dependency on Axios Aug 10, 2022
@BrunnerLivio
Copy link
Member

Fixed with 9.1.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants