Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParseUUIDPipe ignores exceptionFactory when value is not a string #8472

Closed
4 tasks done
titivuk opened this issue Oct 29, 2021 · 1 comment
Closed
4 tasks done

ParseUUIDPipe ignores exceptionFactory when value is not a string #8472

titivuk opened this issue Oct 29, 2021 · 1 comment
Labels
needs triage This issue has not been looked into

Comments

@titivuk
Copy link
Contributor

titivuk commented Oct 29, 2021 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

When ParseUUIDPipe validates not a string value, it ignores exceptionFactory

Minimum reproduction code

https://github.com/titivuk/nestjs-parse-uuid-pipe-issue

Steps to reproduce

  1. npm i
  2. npm run test

Expected behavior

ParseUUIDPipe always has to throw custom exception if it's provided

Package

  • @nestjs/common

NestJS version

8.1.2

Packages versions

  • @nestjs/common: "^8.0.0"
  • @nestjs/core: "^8.0.0"
  • @nestjs/platform-express: "^8.0.0"

Node.js version

16.6.1

In which operating systems have you tested?

  • Windows
  • Linux

Other

PR to fix
#8459
@titivuk titivuk added the needs triage This issue has not been looked into label Oct 29, 2021
@kamilmysliwiec
Copy link
Member

Let's track this here #8459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage This issue has not been looked into
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kamilmysliwiec @titivuk