resolveReference no longer called correctly in latest @apollo/subgraph version

[trevor-scheer]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

Nest appears to depend on some non-public API within the subgraph library by calling the resolveReference functions directly. The location of this function was moved onto the extensions object in latest versions of the @apollo/subgraph library, so the usage needs to be updated here.

I'm not quite sure how users install dependencies and use the nest framework, so this may or may not be a breaking change for your library.

To see the change that was made: apollographql/federation#1747

(I'm going to fill out the rest of the required template bits with nonsense, I'm not going to provide a reproduction but maybe @NeutronScott12 can)

Other useful links:
apollographql/federation#1895

graphql/packages/graphql/lib/utils/transform-schema.util.ts

Lines 31 to 37 in 260ec9e

	interface GraphQLObjectType {
	resolveReference?: any;
	}
	interface GraphQLObjectTypeConfig<TSource, TContext> {
	resolveReference?: any;
	}

graphql/packages/graphql/lib/utils/transform-schema.util.ts

Line 85 in 260ec9e

objectType.resolveReference = type.resolveReference;

And since I noticed it, transformSchema from apollo-tooling is no longer used (it lives in the federation repo now) so this comment should be updated:

graphql/packages/graphql/lib/utils/transform-schema.util.ts

Lines 1 to 3 in 260ec9e

	// This file is copied from `apollo-tooling`. The only difference is that it has a hack to not remove federation specific properties.
	// The changed lines are 31-40 and 85-87 and the original file can be found here:
	// https://github.com/apollographql/apollo-tooling/blob/master/packages/apollo-graphql/src/schema/transformSchema.ts

[NeutronScott12]

Thanks for opening it here.

But it's once you install subgraph 0.4.2, it stops resolving across the services.

I tried with this example - https://github.com/nestjs/nest/tree/master/sample/31-graphql-federation-code-first - and it still didn't work.

But once I changed the version to 0.4.0, it worked again.

[kdawgwilk]

@NeutronScott12 Did you mean subgraph 2.0? 4.0/4.2 doesn't appear to be a valid version

[NeutronScott12]

@NeutronScott12 Did you mean subgraph 2.0? 4.0/4.2 doesn't appear to be a valid version

0.4.2(forgot to add the 0), Nest doesn't work for version 2 of anything of Apollo yet.

[kamilmysliwiec]

Would you like to create a PR to address this issue?

[trevor-scheer]

-> #2245

[kamilmysliwiec]

Thank you @trevor-scheer! Let's track this here #2245