Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible error when updating using deno 1.4 #73

Closed
buttercubz opened this issue Sep 14, 2020 · 8 comments
Closed

possible error when updating using deno 1.4 #73

buttercubz opened this issue Sep 14, 2020 · 8 comments

Comments

@buttercubz
Copy link
Contributor

see denoland/deno#7455

@SteelAlloy
Copy link
Member

This is what I get when installing [email protected]

Windows
image

Linux (WSL)
image

No error is displayed but nothing happens

@buttercubz
Copy link
Contributor Author

No error is displayed but nothing happens

that's the mistake

@yoshixmk
Copy link

Me too.
Run eggs using Deno 1.4, failed after show "success message".

[INFO] Successfully updated .nest-api-key with your key!
[INFO] Formatted your code.
[ERR] deno test returned a non-zero code.
##[error]Process completed with exit code 1.

https://github.com/yoshixmk/deno-x-ranking/runs/1128839330?check_suite_focus=true

So, I avoided it by using it in 1.3.3.

@SteelAlloy
Copy link
Member

SteelAlloy commented Sep 17, 2020

@yoshixmk Your problem is different 😉
Eggs doesn't work for deno 1.4 only if it's installed. By running it with run (which is done in the github action), there is no bug. Your error comes from the fact that the tests you configured didn't pass for your module with Deno 1.4.
By default, eggs runs deno test before releasing to make sure the module is not broken. You can disable this behavior with the option --check-all=false or --no-check-all or by modifying your egg.json file.

@yoshixmk
Copy link

@oganexon Thank you for getting in touch with me.

It's hard to believe, but it happened after I commited to change the version, so I misunderstood it was a related issue.

@mjrlowe
Copy link

mjrlowe commented Sep 19, 2020

This was fixed in Deno 1.4.1! You may need to reinstall eggs after updating Deno, but it seems to work now.

@SteelAlloy
Copy link
Member

Awesome 🚀
I'll test this later in the day

@SteelAlloy
Copy link
Member

Fixed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants