feat: enforce type field of a cellbase output cell must be absent
#335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janx
reviewed
Mar 15, 2019
| @@ -99,6 +90,16 @@ impl<CP: ChainProvider + Clone> CellbaseVerifier<CP> { | |||
| { | |||
| return Err(Error::Cellbase(CellbaseError::InvalidInput)); | |||
| } | |||
|
|
|||
| // currently, we enforce`type` field of a cellbase output cell must be absent | |||
There was a problem hiding this comment.
Currently, we have an involuntary issue that CKB-VM execution skipped cellbase. It's a temporary solution until we implement cellbase type script validation.
There was a problem hiding this comment.
Feels like something we should fix before testnet.
doitian
reviewed
Mar 15, 2019
| @@ -75,9 +69,6 @@ impl<CP: ChainProvider + Clone> CellbaseVerifier<CP> { | |||
| } | |||
|
|
|||
| pub fn verify(&self, block: &Block) -> Result<(), Error> { | |||
| if block.commit_transactions().is_empty() { | |||
There was a problem hiding this comment.
Is cellbase required now? Has it been added in the verification RFC doc?
There was a problem hiding this comment.
Cellbase is always required. RFC updated.
quake
approved these changes
Mar 19, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 19, 2019
335: feat: enforce `type` field of a cellbase output cell must be absent r=doitian a=zhangsoledad * remove redundant EmptyVerifier * enforce `type` field of a cellbase output cell must be absent Co-authored-by: zhangsoledad <[email protected]>
Build succeeded
|
Merged
bors bot
added a commit
that referenced
this pull request
Sep 14, 2019
1583: chore(deps): bump chrono from 0.4.8 to 0.4.9 r=zhangsoledad a=dependabot-preview[bot] Bumps [chrono](https://github.com/chronotope/chrono) from 0.4.8 to 0.4.9. <details> <summary>Changelog</summary> *Sourced from [chrono's changelog](https://github.com/chronotope/chrono/blob/master/CHANGELOG.md).* > ## 0.4.9 > > ### Fixes > > * Make Datetime arithmatic adjust their offsets after discovering their new > timestamps ([@​quodlibetor](https://github.com/quodlibetor) [#337](https://github-redirect.dependabot.com/chronotope/chrono/issues/337)) > * Put wasm-bindgen related code and dependencies behind a `wasmbind` feature > gate. ([@​quodlibetor](https://github.com/quodlibetor) [#335](https://github-redirect.dependabot.com/chronotope/chrono/issues/335)) </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/chronotope/chrono/commits/v0.4.9) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=chrono&package-manager=cargo&previous-version=0.4.8&new-version=0.4.9) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typefield of a cellbase output cell must be absent