fix: use forked metrics and forked sentry to fix RUSTSEC-2020-0041 temporarily #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
requested review from
doitian,
jjyr,
keroro520,
quake,
TheWaWaR and
zhangsoledad
as code owners
doitian
reviewed
Sep 8, 2020
util/app-config/src/sentry_config.rs
Outdated
| @@ -31,8 +27,6 @@ impl SentryConfig { | |||
| scope.set_extra("org_contact", org_contact.clone().into()); | |||
| } | |||
| }); | |||
|
|
|||
| register_panic_handler(); | |||
There was a problem hiding this comment.
How the sentry panic handler is registered in the new version?
There was a problem hiding this comment.
doitian
previously approved these changes
Sep 8, 2020
driftluo
previously approved these changes
Sep 8, 2020
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Sep 8, 2020
2266: fix: use forked metrics and forked sentry to fix RUSTSEC-2020-0041 temporarily r=yangby-cryptape a=yangby-cryptape ### Commits - [chore(deps): bump crossbeam-channel from 0.4.3 to 0.4.4](728f5c3) - [chore: remove direct dependencies of metrics exporters and observers](de3173a) - [chore(deps): bump sentry from 0.16.0 to 0.19.1](e6b00c5) - [The module `sentry::internals` was deprecated.](https://github.com/getsentry/sentry-rust/blob/0.19.1/sentry/src/lib.rs#L133) - [`Sentry` will set itself as the panic handler automatically on setup, so no need to do that manually](../../../../getsentry/sentry-rust/issues/235#issuecomment-654832365) - [chore: replace several dependencies sentry by sentry-core and sentry-log](80af819) - [fix: use patched versions of metrics and sentry to fix RUSTSEC-2020-0041 temporarily](1eb9e0b) - [Changes of forked `metrics`](nervosnetwork/sentry-rust@1cdb9ff) - [Changes of forked `sentry`](nervosnetwork/metrics-rs@4fd13f6) ### References - [RUSTSEC-2020-0041](../../../../rustsec/advisory-db/pull/381) Co-authored-by: Boyu Yang <[email protected]>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Sep 8, 2020
2266: fix: use forked metrics and forked sentry to fix RUSTSEC-2020-0041 temporarily r=yangby-cryptape a=yangby-cryptape ### Commits - [chore(deps): bump crossbeam-channel from 0.4.3 to 0.4.4](728f5c3) - [chore: remove direct dependencies of metrics exporters and observers](de3173a) - [chore(deps): bump sentry from 0.16.0 to 0.19.1](e6b00c5) - [The module `sentry::internals` was deprecated.](https://github.com/getsentry/sentry-rust/blob/0.19.1/sentry/src/lib.rs#L133) - [`Sentry` will set itself as the panic handler automatically on setup, so no need to do that manually](../../../../getsentry/sentry-rust/issues/235#issuecomment-654832365) - [chore: replace several dependencies sentry by sentry-core and sentry-log](80af819) - [fix: use patched versions of metrics and sentry to fix RUSTSEC-2020-0041 temporarily](1eb9e0b) - [Changes of forked `metrics`](nervosnetwork/sentry-rust@1cdb9ff) - [Changes of forked `sentry`](nervosnetwork/metrics-rs@4fd13f6) ### References - [RUSTSEC-2020-0041](../../../../rustsec/advisory-db/pull/381) Co-authored-by: Boyu Yang <[email protected]>
|
Build failed:
|
yangby-cryptape
dismissed stale reviews from driftluo and doitian
via
6aaae31
yangby-cryptape
force-pushed
the
pr/fix-rustsec-2020-0041
branch
from
1eb9e0b
to
6aaae31
Compare
|
The last force-pushed replace I don't have Mac, so it's too hard to debug it for me via Travis CI. I gave up! |
driftluo
approved these changes
Sep 9, 2020
doitian
approved these changes
Sep 11, 2020
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits
metricssentryReferences