Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: unify h256 and ProposalShortId serialization #125

Merged
merged 6 commits into from
Dec 29, 2018
Merged

refactor: unify h256 and ProposalShortId serialization #125

merged 6 commits into from
Dec 29, 2018

Conversation

quake
Copy link
Member

@quake quake commented Dec 25, 2018 •
edited
Loading

This PR did code refactoring for H256 serialization. Needs rebase after #119

TODO:

  • 1. Should we unify these Bytes field also?
    NO difficulty / U256
    YESproposal_transactions and short_ids / [u8; 10]

  • 2. Client SDK change

@doitian
Copy link
Member

doitian commented Dec 26, 2018

Are you plan to change other fixed array in this PR?

@quake
Copy link
Member Author

quake commented Dec 26, 2018

Are you plan to change other fixed array in this PR?

Yes, plan to change ShortId to [u8; 10], will push it later.

@quake quake changed the title [WIP] refactor: unify h256 serialization refactor: unify h256 and ProposalShortId serialization Dec 28, 2018
@xxuejie xxuejie mentioned this pull request Dec 28, 2018
Merged
@quake quake merged commit 62f57c0 into develop Dec 29, 2018
@quake quake deleted the quake/h256_ser branch December 29, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxuejie xxuejie xxuejie left review comments

@doitian doitian doitian left review comments

@zhangsoledad zhangsoledad zhangsoledad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quake @doitian @xxuejie @zhangsoledad