Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map attributes #113

Merged
merged 2 commits into from
May 2, 2021
Merged

Map attributes #113

merged 2 commits into from
May 2, 2021

Conversation

mikesplain
Copy link

Add the ability to map attributes the way we already can for map_state. This works well for things like media players where you may want to look up attribute values and map it to ui values.

Fixes #109

@nervetattoo
Copy link
Owner

Awesome, thanks!
Only problem is that the latest version of the code resides in the beta branch and has been ported to Typescript and re-organized. Do you want to re-apply the fix towards the beta branch? If not I can manually merge it and port it when I find the time, making sure that I attribute the commit to you.

@mikesplain mikesplain changed the base branch from master to beta May 2, 2021 14:13
@mikesplain
Copy link
Author

Thanks @nervetattoo! Rebased and retargeted to the beta branch, thanks for the clean migration to TS, super easy rebase. Let me know if you need anything else from me!

@nervetattoo nervetattoo merged commit a456f0c into nervetattoo:beta May 2, 2021
@nervetattoo
Copy link
Owner

Looked clean and nice. Thanks for the addition, it makes super sense so 👍

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

🎉 This PR is included in version 1.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mikesplain mikesplain deleted the map_attributes branch May 2, 2021 21:33
@mikesplain
Copy link
Author

Awesome thanks! I have some more code that I’ll rework and contribute soon too. Thanks for the great plugin!

crempp added a commit to crempp/banner-card that referenced this pull request Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map_state when using entity.attribute
2 participants